Feature/hw-02 - #2
Open
uoles wants to merge 17 commits into
Open
Conversation
uoles
commented
Mar 21, 2019
uoles
commented
Owner
- Локализация для вопросов и сообщений.
- Файл настроек.
- Java + Annotation-based конфигурация.
- Использование lombok.
- Добавление исключения QuestionsFileLoadingException. - Работа с консолью вынесена в сервис ConsoleService. - Тесты для QuestionsDAO.
- Добавлены тесты.
- Изменения в структуре файлов.
- Использование библиотеки lombok.
- Файл настроек. - Java + Annotation-based конфигурация.
saroff
reviewed
Mar 21, 2019
|
|
||
| @Setter | ||
| @Getter | ||
| private String id; |
There was a problem hiding this comment.
Есть @Data, она сразу сгенерит все нужное :)
| @Test | ||
| @DisplayName("Корректное заполнение") | ||
| public void fillQuestionTest() { | ||
| Question question = new Question( |
There was a problem hiding this comment.
Этот тест излишний, нет смысла тестировать классы которые только хранят данные.
| @Test | ||
| @DisplayName("Корректное создание") | ||
| public void createUserTest() { | ||
| User user = new User(c_userName, c_userSurname); |
|
|
||
| assertAll("questions", | ||
| () -> assertNotNull(questions), | ||
| () -> assertEquals(3, questions.size()), |
| @@ -0,0 +1,3 @@ | |||
| 1,Тест1,Ответ1,Ответ2,Ответ3,Ответ4,Ответ1 | |||
| 2,Тест2,Ответ1,Ответ2,Ответ3,Ответ4,Ответ1 | |||
There was a problem hiding this comment.
Отлично что используете отдельные данные для тестов.
saroff
reviewed
Mar 23, 2019
| * Time: 15:54 | ||
| */ | ||
|
|
||
| @Data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.